Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code and testing #18

Merged
merged 51 commits into from
Feb 16, 2021
Merged

Improve code and testing #18

merged 51 commits into from
Feb 16, 2021

Conversation

uvchik
Copy link
Member

@uvchik uvchik commented Jan 26, 2021

We published v0.2.0 to make it easier to use the new deflex but there is still some work to do:

  • increase test coverage
  • fix code style issues (lgtm, codacy)
  • search for bugs
  • improve documentation
  • improve examples
  • Move data to scenario builder or reegis
  • Activate scenario builder as optional feature (scenario builder is an extra requirement)

Afterwards we will release a new version. If there are urgent issues found, there might be hot-release or a pre-release.

@uvchik uvchik self-assigned this Jan 26, 2021
@uvchik uvchik added this to the v0.2.1 milestone Jan 26, 2021
@uvchik uvchik added the enhancement New feature or request label Jan 26, 2021
@codecov-io
Copy link

codecov-io commented Jan 26, 2021

Codecov Report

Merging #18 (fe60bbb) into master (1e1e923) will increase coverage by 7.81%.
The diff coverage is 97.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   74.17%   81.99%   +7.81%     
==========================================
  Files          20       19       -1     
  Lines        1336     1333       -3     
  Branches      237      224      -13     
==========================================
+ Hits          991     1093     +102     
+ Misses        280      183      -97     
+ Partials       65       57       -8     
Impacted Files Coverage Δ
src/deflex/scenario_builder.py 18.33% <0.00%> (ø)
src/deflex/scenario_tools.py 84.44% <85.71%> (-0.04%) ⬇️
src/deflex/config.py 98.71% <92.85%> (+35.08%) ⬆️
src/deflex/__init__.py 100.00% <100.00%> (ø)
src/deflex/analyses.py 95.87% <100.00%> (+0.08%) ⬆️
src/deflex/main.py 86.77% <100.00%> (ø)
src/deflex/tools.py 100.00% <100.00%> (+62.50%) ⬆️
tests/test_config.py 100.00% <100.00%> (ø)
tests/test_tools.py 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e1e923...fe60bbb. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Jan 26, 2021

Hello @uvchik! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 239:75: E203 whitespace before ':'

Comment last updated at 2021-02-16 09:57:38 UTC

@uvchik uvchik changed the title Bump version number Improve code and testing Feb 12, 2021
@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request introduces 1 alert when merging 946bb06 into 1e1e923 - view on LGTM.com

new alerts:

  • 1 for Unused import

@uvchik uvchik merged commit 45d8ba8 into master Feb 16, 2021
@uvchik uvchik deleted the improve_code branch February 16, 2021 10:04
@uvchik uvchik restored the improve_code branch February 16, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants