Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten isCommit and isPRCommit pattern #110

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Tighten isCommit and isPRCommit pattern #110

merged 1 commit into from
Jan 14, 2022

Conversation

kidonng
Copy link
Member

@kidonng kidonng commented Jan 10, 2022 •
edited

Commit URLs can end with .diff or .patch, but they are not actually commits.

Note: there are similar suffixes for other types page as well:

@fregante
Copy link
Member

It makes sense but does this solve any issues? Most other features that are isRepo-based will still run and fail, right? I'm surprised if extensions are still injected on non-html files.

@kidonng
Copy link
Member Author

kidonng commented Jan 13, 2022 •
edited

It's not for browser extensions but rather my GitHub Hovercards user script. It applies to most GitHub links that match isProfile, isCommit etc.

The .patch and .diff links added by Refined GitHub match as well, but there's no hovercards for them.

Since opening this PR I have updated the script to remove those suffixes, but it would probably benefit others as well. This also aligns with other items I listed in PR description.

@kidonng kidonng merged commit 91f1e93 into main Jan 14, 2022
@kidonng kidonng deleted the tighten-commit-pattern branch January 14, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante fregante approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kidonng @fregante