Skip to content

Conversation

fregante
Copy link
Member

@fregante fregante commented Apr 9, 2023

@fregante fregante marked this pull request as ready for review April 9, 2023 10:28
@fregante
Copy link
Member Author

fregante commented Apr 9, 2023

I'm debating whether this is useful compared to just (somehow) linking to the source:

export const isReleasesOrTags = (url: URL | HTMLAnchorElement | Location = location): boolean => isReleases(url) || isTags(url) || isSingleTag(url);
addTests('isReleasesOrTags', [
'isReleases',
'isTags',
'isSingleTag',
]);
export const isDeletingFile = (url: URL | HTMLAnchorElement | Location = location): boolean => Boolean(getRepo(url)?.path.startsWith('delete'));
addTests('isDeletingFile', [
'https://github.com/sindresorhus/refined-github/delete/master/readme.md',
'https://github.com/sindresorhus/refined-github/delete/ghe-injection/source/background.ts',
]);

Also I think that it would be best to generate a docs.md and commit it rather than add this to the demo site. GitHub’s markdown parser and git history is better than this.

@fregante
Copy link
Member Author

fregante commented Apr 14, 2023

Merging for now, but eventually it's best to move this to a generated markdown instead, maybe.

This already works so it's better than nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant