Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default i18n namespace set in the some hooks #3436

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

sevkioruc
Copy link
Contributor

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Test plan (required)

Demonstrate the code is solid. If not, please add WIP: in its title.

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

Self Check before Merge

Please check all items below before review.

  • Corresponding issues are created/updated or not needed
  • Docs are updated/provided or not needed
  • Examples are updated/provided or not needed
  • TypeScript definitions are updated/provided or not needed
  • Tests are updated/provided or not needed
  • Changesets are provided or not needed

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2023

🦋 Changeset detected

Latest commit: a6ba733

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 21, 2023

Deploy Preview for refine-doc-live-previews ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a6ba733
🔍 Latest deploy log https://app.netlify.com/sites/refine-doc-live-previews/deploys/63ce5f9bd426de00093e1053
😎 Deploy Preview https://deploy-preview-3436--refine-doc-live-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@omeraplak omeraplak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM! 🏆

@omeraplak
Copy link
Member

Hey @sevkioruc ,
Could you add a changeset? https://refine.dev/docs/contributing/#changeset

@omeraplak omeraplak linked an issue Jan 21, 2023 that may be closed by this pull request
@sevkioruc
Copy link
Contributor Author

Hey @omeraplak ,
Could you pleae review again?

.changeset/rich-buttons-clean.md Outdated Show resolved Hide resolved
@omeraplak omeraplak merged commit ea74f3a into refinedev:next Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] i18n notification message
3 participants