fix missing template error and simplify code

refinery · Jul 30, 2012 · c6149b6 · c6149b6
1 parent a31b2e4
commit c6149b6
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/pages/app/controllers/refinery/admin/pages_dialogs_controller.rb b/pages/app/controllers/refinery/admin/pages_dialogs_controller.rb
@@ -51,6 +51,7 @@ def link_to
       end
 
       def test_url
+        result = 'failure'
         begin
           timeout(5) do
             unless params[:url].blank?
@@ -62,16 +63,16 @@ def test_url
               result = case Net::HTTP.get_response(url)
                 when Net::HTTPSuccess, Net::HTTPRedirection
                   'success'
-                else
-                  'failure'
                 end
-
-              render :json => {:result => result}
+
             end
           end
+
         rescue
-          render :json => {:result => 'failure'}
+          # be quiet
         end
+
+        render :json => {:result => result}
       end
 
       def test_email