Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragonfly S3 support need not be required by default #2859

Closed
parndt opened this issue Jan 26, 2015 · 2 comments
Closed

Dragonfly S3 support need not be required by default #2859

parndt opened this issue Jan 26, 2015 · 2 comments

Comments

@parndt
Copy link
Member

parndt commented Jan 26, 2015

When @simi migrated us to version 1.0.0 of Dragonfly (thanks!) dragonfly-s3_data_store came along for the ride.

This comes with an enormous amount of sub-dependencies (i.e. all of fog) which isn't required unless s3 is actually being used.

Is there any way that we can optionally support it? Maybe if --heroku is specified when using the installer templates or if --s3 is specified (which doesn't currently exist)?

Or, we can just carry on like we have..

@simi
Copy link
Member

simi commented Jan 26, 2015

I think it should be removed as a hard dependency and properly documented (actually link to http://markevans.github.io/dragonfly/data-stores/ is enough IMHO).

@parndt
Copy link
Member Author

parndt commented Jan 26, 2015

We'll have to make the --heroku installation option work as before, though.. or maybe this doesn't rely on S3 to get started?

parndt added a commit that referenced this issue Jan 26, 2015
@parndt parndt closed this as completed in 26ff71f Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants