Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dragonfly initializer to be compatible with dragonfly s3 datastore #3376

Closed
kluucreations opened this issue Jul 6, 2018 · 6 comments

Comments

@kluucreations
Copy link
Contributor

s3_datastore initialization is passing invalid opts into s3_data_store.
Update field names so that config values can be picked up succesfully

bricesanchez pushed a commit that referenced this issue Aug 21, 2018
parndt pushed a commit that referenced this issue Aug 22, 2018
@robbyrussell
Copy link

robbyrussell commented Nov 29, 2018

@bricesanchez Hiya! -- was this released in 4.0.3?

@robbyrussell
Copy link

We ran into a problem upgrading a Rails 4 Refinery site to Rails 5 and bumping up Refinery in the process with the S3/Dragonfly configurations. We found the fix for this would resolve our config problem but wasn't in latest Rubygem releases. We're tracking 4-0-stable for now

@bricesanchez
Copy link
Member

Hi @robbyrussell !

Yes it has been release to 4.0.3 : 8222955
https://github.com/refinery/refinerycms/commits/4-0-stable

@parndt
Copy link
Member

parndt commented Nov 30, 2018

@robbyrussell curious.. maybe I didn't release it properly 😭

By the way thank you so much for Oh My Zsh!

@parndt
Copy link
Member

parndt commented Nov 30, 2018

🤦‍♂️ I know what's going on. This code belongs in the refinerycms-dragonfly gem, and that hasn't been released with a new version. I'll push version 1.0.1

parndt added a commit that referenced this issue Nov 30, 2018
This was missed as part of the refinerycms v4.0.3 release.
Fixes #3376
parndt added a commit that referenced this issue Nov 30, 2018
This was missed as part of the refinerycms v4.0.3 release.
Fixes #3376
@parndt
Copy link
Member

parndt commented Nov 30, 2018

@robbyrussell it's released as refinerycms-dragonfly 1.0.1 - please let me know how you get on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants