Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding link to page when switch locale in administration #1583

Merged
merged 1 commit into from
Apr 24, 2012

Conversation

vita
Copy link
Contributor

@vita vita commented Apr 10, 2012

No description provided.

@parndt
Copy link
Member

parndt commented Apr 10, 2012

cc @ugisozols @simi

Any tests that would help here?

Thanks!

@simi
Copy link
Member

simi commented Apr 10, 2012

@vita can you write some scenario why this is needed? I'll write test and test it.

@vita
Copy link
Contributor Author

vita commented Apr 10, 2012

@simi: when switch locale (to :cs, :en is default) on edit page and add link to page then wymeditor insert bad link ("/cs/about-en", correct is "/cs/about-cs").

::I18n.locale = :cs
@page.nested_path => "/about-cs"

::I18n.locale = :en
@page.nested_path => "/about-en"

Globalize.locale = :cs
@page.nested_path => "/about-en" 

Globalize.locale = :en
@page.nested_path => "/about-en"

@parndt
Copy link
Member

parndt commented Apr 11, 2012

Thanks guys

@travisbot
Copy link

This pull request passes (merged 7865cc5 into 5834331).

@simi
Copy link
Member

simi commented Apr 22, 2012

@travisbot welcome

@parndt
Copy link
Member

parndt commented Apr 22, 2012

@simi it's truly awesome huh :-)

@parndt
Copy link
Member

parndt commented Apr 22, 2012

@simi do you still plan to write a test for this?

ugisozols added a commit that referenced this pull request Apr 24, 2012
ugisozols added a commit that referenced this pull request Apr 24, 2012
Fix adding link to page when switch locale in administration
@ugisozols ugisozols merged commit a0513cf into refinery:master Apr 24, 2012
ugisozols added a commit that referenced this pull request Apr 24, 2012
@JohnColvin
Copy link

I'm using 2.0.8 and I'm still having this issue. I get a 404 from this URL http://localhost:3000/refinery/dialogs/Link?wymeditor=true&null since it doesn't use locale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants