Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix adding link to page when switch locale in administration #1583

Merged
merged 1 commit into from Apr 24, 2012

Conversation

Projects
None yet
6 participants
Contributor

vita commented Apr 10, 2012

No description provided.

Owner

parndt commented Apr 10, 2012

cc @ugisozols @simi

Any tests that would help here?

Thanks!

Member

simi commented Apr 10, 2012

@vita can you write some scenario why this is needed? I'll write test and test it.

Contributor

vita commented Apr 10, 2012

@simi: when switch locale (to :cs, :en is default) on edit page and add link to page then wymeditor insert bad link ("/cs/about-en", correct is "/cs/about-cs").

::I18n.locale = :cs
@page.nested_path => "/about-cs"

::I18n.locale = :en
@page.nested_path => "/about-en"

Globalize.locale = :cs
@page.nested_path => "/about-en" 

Globalize.locale = :en
@page.nested_path => "/about-en"
Owner

parndt commented Apr 11, 2012

Thanks guys

This pull request passes (merged 7865cc5 into 5834331).

Member

simi commented Apr 22, 2012

@travisbot welcome

Owner

parndt commented Apr 22, 2012

@simi it's truly awesome huh :-)

Owner

parndt commented Apr 22, 2012

@simi do you still plan to write a test for this?

@ugisozols ugisozols added a commit that referenced this pull request Apr 24, 2012

@ugisozols ugisozols Add failing spec for #1583 52218e9

@ugisozols ugisozols added a commit that referenced this pull request Apr 24, 2012

@ugisozols ugisozols Merge pull request #1583 from SmartMedia/nested_path
Fix adding link to page when switch locale in administration
a0513cf

@ugisozols ugisozols merged commit a0513cf into refinery:master Apr 24, 2012

@ugisozols ugisozols added a commit that referenced this pull request Apr 24, 2012

@ugisozols ugisozols Add failing spec for #1583 4494ffc

I'm using 2.0.8 and I'm still having this issue. I get a 404 from this URL http://localhost:3000/refinery/dialogs/Link?wymeditor=true&null since it doesn't use locale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment