added ajaxy image uploading

[jipiboily]

Here is the handling of image uploading with an ajaxy touch. It will upload files one by one instead of a single batch. This will prevent timeouts on say, Heroku.

It was asked by @robyurkowski here https://github.com/resolve/refinerycms/issues/1329#issuecomment-4862916. It was previously handled by https://github.com/jipiboily/refinerycms-imajax.

There is only one problem I see is the handling of I18n on the client side. I used the same method as you use in core, but it proved to be inefficient while I tested that. All the output will be in english even if there is a french translation. How would you want to support that?

Hope it's up to what you expected, if not, do not hesitate to comment or make suggestions. Friendly bashing accepted! ;)

[travisbot]

This pull request passes (merged 8a76e35 into 10337cb).

[parndt]

<% if @image.errors.empty? %>

[jipiboily]

Will modify

[travisbot]

This pull request fails (merged cbc514f9 into 10337cb).

[travisbot]

This pull request passes (merged a41ad9e into 290fd4e).

[travisbot]

This pull request passes (merged 81f63d8 into 290fd4e).

[travisbot]

This pull request fails (merged 9dbeccf into 290fd4e).

[ugisozols]

I would like for the dialog to close after I upload images because currently it just stays open showing success message and you have to close it yourself.

[jipiboily]

@ugisozols should it be closed right away and the flash message should then be showed where it was before?

[ugisozols]

@jipiboily yes.

[parndt]

I'm guessing the last request added somewhat of a challenge?

[jipiboily]

@parndt things in my personal life kept me away from coding...I will do that really soon. I might have to play with the flash header to append all file names to the message...

[parndt]

@jipiboily I believe so yes! :-)

[jipiboily]

I finally removed the flash, it felt too hacky.

It will automatically close the dialog after a successful upload and will show that: http://cl.ly/1f0h2W2g1V450w3M3L0T

Is that what you imagined?

[travisbot]

This pull request passes (merged 0e3037d into c3c3dd7).

[ugisozols]

@jipiboily yes.

[robyurkowski]

@jipiboily What does it show when you upload multiple while inserting?

[jipiboily]

@robyurkowski not sure to understand what you mean. You mean during the process? You want me to shoot a video of the process? :)

[robyurkowski]

Like if I'm uploading while inserting into a page. What is the behaviour then?

[jipiboily]

Hum, it is closing the dialog now...which is unexpected in this specific use case, and unwanted.

[jipiboily]

Two choices guys from here. Or we don't close the dialog automatically in neither of the situations, or we don't close it when inserting an image into a page. What would you prefer?

[ugisozols]

@jipiboily can you make it behave the same as it is now? Thanks.

[jipiboily]

Sure, I'll do!

[travisbot]

This pull request passes (merged c4873b1 into 765174c).

[jipiboily]

Hi guys! I made it working mostly like it is now as far as I know. If I missed something (I didn't use Refinery that much), do not hesitate to tell me!

Cheers

[travisbot]

This pull request fails (merged 4b3a41d into 765174c).

[ugisozols]

Hey @jipiboily,

Just tried out this and it works great! Can you do 2 more things?

• Remove flash message from the dialog window - while you upload images it shows status and after the upload is complete it shows flash message in the same window. Right after that it closes window and redisplays flash message in the main page which is enough.
• Add changelog entry

Thanks!

[parndt]

I would love to get this merged soon as it's a nice feature. @ugisozols @robyurkowski maybe we could implement the last couple of items?

[ugisozols]

I did the changes I wanted and pushed to a new branch because I couldn't open a PR against @jipiboily repo.

Please review.

[jipiboily]

I just got back from 3 weeks of vacations. Thanks for putting the last touch @ugisozols!

[jokklan]

Is someone currently working on this?

[ugisozols]

Nope.