Refactored CLI override command to use Thor. #2042
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: The tests FAIL
This is because cli_spec.rb is testing the output of the
rake
command. I think this is silly.If we're testing the CLI we should be testing the CLI class, not the
rake
command.Permission to refactor these specs to test the class instead?
Here's how you'd call it:
Seems better to me.
@robyurkowski @ugisozols Please give me your feedback.