Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #2836
I believe I have fixed three small bugs I discovered as part of trying to resolve the above issue:
extend Refinery::Testing::FeatureMacros::Authenication
to the features/admin spec generator.rspec-its
gem to the engine Gemfile templateNow, my tests are still failing because it can't
visit refinery.some_admin_path
:Any assistance to nail this next issue down would be very welcome!
cheers,
Chris
NOTE:
Re: 1) I am surprised this was needed as it wasn't in previous versions. I think there is a better way. E.g., the file
core/spec/support/refinery.rb
which does theextend
as default for all feature specs. Presumably this support file could be added to the Engine generator... I believe that or something similar would probably be a better fix. Comments?Can you shed any light on what might have changed to break the engine specs?