Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rspec issue in Engine generator #2842

Closed
wants to merge 2 commits into from
Closed

Conversation

CJYate
Copy link
Contributor

@CJYate CJYate commented Jan 20, 2015

Re: #2836

I believe I have fixed three small bugs I discovered as part of trying to resolve the above issue:

  1. commit 9487762: refinery_login_as function wasn't found: add extend Refinery::Testing::FeatureMacros::Authenication to the features/admin spec generator.
  2. commit df6f299: add rspec-its gem to the engine Gemfile template
  3. commit 9487762: Correct the symbol name for refinery_user for login

Now, my tests are still failing because it can't visit refinery.some_admin_path:

 Refinery Bleeees Admin bleeees destroy should succeed
     Failure/Error: visit refinery.bleeees_admin_bleeees_path
     NameError:
       undefined local variable or method `refinery' for #<RSpec::ExampleGroups::Refinery::Bleeees::Admin::Bleeees::Destroy:0x00000008268fb0>

Any assistance to nail this next issue down would be very welcome!
cheers,
Chris

NOTE:

Re: 1) I am surprised this was needed as it wasn't in previous versions. I think there is a better way. E.g., the file core/spec/support/refinery.rb which does the extend as default for all feature specs. Presumably this support file could be added to the Engine generator... I believe that or something similar would probably be a better fix. Comments?

Can you shed any light on what might have changed to break the engine specs?

@parndt
Copy link
Member

parndt commented Jan 21, 2015

This was fixed in #2843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants