Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2836 by updating rspec syntax in generated files. #2843

Merged
merged 1 commit into from
Jan 21, 2015

Conversation

parndt
Copy link
Member

@parndt parndt commented Jan 21, 2015

@@ -25,6 +25,7 @@ platforms :ruby do
end

group :development, :test do
gem 'rspec-its' # for the model's validation tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about to move this dep. into refinerycms-testing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Refinery itself need it? I feel like people should know they're only opting in as their extensions are using it.

parndt added a commit that referenced this pull request Jan 21, 2015
Fixes #2836 by updating rspec syntax in generated files.
@parndt parndt merged commit 0252e17 into master Jan 21, 2015
@parndt parndt deleted the fix-issue/2836 branch January 21, 2015 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants