Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent deployment to hosting when running tests #3222

Merged
merged 1 commit into from
Jul 19, 2016

Conversation

parndt
Copy link
Member

@parndt parndt commented Jul 18, 2016

This is for a change introduced with #3213

@parndt
Copy link
Member Author

parndt commented Jul 18, 2016

@bricesanchez I want to merge this soon, and we can bring it back once we address a smart way of blocking the deployment aspect of the --heroku flag, what do you think about that?

@parndt parndt force-pushed the bugfix/cms-generator-heroku branch from 3502f55 to fc3fab5 Compare July 19, 2016 00:31
@parndt
Copy link
Member Author

parndt commented Jul 19, 2016

Of note is that the flag isn't doing anything that is being tested anyway because the tests pass on this PR

@bricesanchez
Copy link
Member

Waiting for CI then i will merge it.

@bricesanchez bricesanchez merged commit 7a2b862 into master Jul 19, 2016
@bricesanchez bricesanchez deleted the bugfix/cms-generator-heroku branch July 19, 2016 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants