Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to fix TODO # bin/refinerycms:301 #458

Merged
1 commit merged into from
Feb 8, 2011
Merged

Conversation

othatbrian
Copy link
Contributor

I attempted to install refinerycms on an ubuntu server. I was missing several packages, so gem installations [from refinerycms] kept bombing, and I kept having to remove my installation and try again (after installing O/S packages). I wanted to change it and noticed in bin/refinerycms @ line 301 the "TODO" to add return value checking after gem installs.

The pull request here includes a simple check after the "bundle install" command, which I found to work very well when a [necessary] gem can't be installed (because, for example, an O/S package is missing). I was NOT able to cause the "bundle update" to fail, so I could not test that. Possibly this same snippet of code (lines 310-315) could be applied at line 306 as well?

This is my 1st ever open source patch contribution/suggestion, so please take it easy on me!

@parndt
Copy link
Member

parndt commented Feb 8, 2011

This is awesome, I've just expanded on what you've done including support for bundle update and I'll push this shortly.

@parndt
Copy link
Member

parndt commented Feb 8, 2011

Tip: To test failure on bundle update I went into the rails console and then modified one of the Gemfile lines' versions to be say, '~> aad0.9' which causes a failure, then ran bundle update and checked $? afterward.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants