Suggestion to fix TODO # bin/refinerycms:301 #458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to install refinerycms on an ubuntu server. I was missing several packages, so gem installations [from refinerycms] kept bombing, and I kept having to remove my installation and try again (after installing O/S packages). I wanted to change it and noticed in bin/refinerycms @ line 301 the "TODO" to add return value checking after gem installs.
The pull request here includes a simple check after the "bundle install" command, which I found to work very well when a [necessary] gem can't be installed (because, for example, an O/S package is missing). I was NOT able to cause the "bundle update" to fail, so I could not test that. Possibly this same snippet of code (lines 310-315) could be applied at line 306 as well?
This is my 1st ever open source patch contribution/suggestion, so please take it easy on me!