Skip to content

Conversation

FHU-yezi
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

  • New feature (non-breaking change which adds functionality)

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

This Pull Request aims to fix some warning in {project-name.py} and pcconfig.py after run pc init to start a new project.

Also use # type: ignore to slient the "Module is not callable" warning provided by Pyright or other type checkers, it can reduce the noise for new guys.

@FHU-yezi FHU-yezi requested a review from picklelo February 11, 2023 00:13
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@picklelo picklelo merged commit 094082c into reflex-dev:main Feb 12, 2023
@FHU-yezi FHU-yezi deleted the better-start branch February 12, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants