Skip to content

Null guard #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2015
Merged

Null guard #8

merged 1 commit into from
Jul 14, 2015

Conversation

bevacqua
Copy link
Contributor

Current implementation would throw if null is passed

kevva added a commit that referenced this pull request Jul 14, 2015
@kevva
Merge pull request #8 from bevacqua/patch-1
ab9cabd 
Null guard
@kevva kevva merged commit ab9cabd into regexhq:master Jul 14, 2015
@tunnckoCore
Copy link
Member

@bevacqua I'll release it in a bit.
@kevva thanks

@bevacqua
Copy link
Contributor Author

FWIW most of these packages seem to have the bug

@tunnckoCore
Copy link
Member

@bevacqua yea we should update them @regexps/owners

release as v1.0.3, thanks for PR

@bevacqua bevacqua deleted the patch-1 branch July 14, 2015 15:46
@jonschlinkert
Copy link
Member

fwiw most of these libs (should) only return a regex, without testing values or doing matching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bevacqua @tunnckoCore @jonschlinkert @kevva