Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_sources: ignore preview candidate (pc) versions #1991

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

igorsafo
Copy link
Contributor

@igorsafo igorsafo commented Jan 10, 2024

This is a fix for #1550
#1441 would be really great to fix this issue for everybody in long term.

Here is branch naming convention in oneDNN: oneapi-src/oneDNN#1779

@igorsafo igorsafo changed the title update_sources: ignore pre-release candidate (pc) versions update_sources: ignore preview candidate (pc) versions Jan 10, 2024
@beckermr beckermr merged commit 680ebcb into regro:master Jan 11, 2024
2 checks passed
@igorsafo
Copy link
Contributor Author

@beckermr Thanks for promoting the change! Is there a way to add the missing/latest releases? oneDNN already released rls-v3.3.4, but due to rls-v3.3-pc there are no updates on conda after rls-v3.3

@beckermr
Copy link
Contributor

You'll need to adjust the latest version in the bot metadata.

@igorsafo
Copy link
Contributor Author

igorsafo commented Jan 11, 2024

You'll need to adjust the latest version in the bot metadata.

Do I understand correctly that I should change this file https://github.com/regro/cf-graph-countyfair/blob/master/versions/8/f/1/9/b/onednn.json to something like "new_version": "3.3" and let the bot to pickup the latest version?

Update: regro/cf-graph-countyfair#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants