Repository navigation
Added:
--dateoption to thea_proprevhelper, so tests can fix the date that the
document id is built from. It follows the convention already used by
a_proposal,a_grppub_readlist,u_milestoneandl_progressreport.doe_otheranddoe_appropriateness_data_management_planfields to the
proposalReviewsschema, so that the prompts a_proprev now writes validate.a_expenseanda_presentationnow itemize breakfast, lunch, dinner and
incidentals for every day of a trip, from the begin date to the end date. Each
amount is drawn uniformly from the mean rate for that meal plus or minus 20%, so
meals that were not taken or were paid for by someone else can simply be deleted.--no-mealsoption toa_expenseanda_presentation, which leaves the
meals off. The meals are added by default.--seedoption toa_expenseanda_presentation, which fixes the meal
amounts. Used for testing.doe_appropriateness_data_management_plananddoe_otherto the exemplar DOE
proposal review, so the new sections of the report are covered by the tests.meals-logbuilder, which fills the UCSB daily meals log with the meals left on
a travel expense.regolith build meals-logbuilds the expenses of the
default_user_idthat have still to be submitted,--people <person>builds
for somebody else, and--kwargs _id:<id>builds one named expense whatever its
status and whoever its payee. One form is written per expense that has meals on
it, and a trip longer than the 19 rows the form carries is written over as many
copies as it needs.ucsb-meals-log.pdf, the empty form, to the templates folder. It is a fillable
AcroForm, so the builder sets the field values rather than rendering a template,
and the form the university issued is passed through untouched.pypdfto the requirements, used to fill the form.
Changed:
- Update template for new DOE proposals with new DOE requirements
- The mean dinner rate is now 42.50 USD and incidentals 5.00 USD, down from 55.00 and
10.00. The four means now sum to 84.50, which keeps a day inside the 92 USD limit
about nine times in ten. - Database directory and file paths in
tools.dbdirname,tools.dbpathname,
fsclient.py,mongoclient.pyanddatabase.xshare now composed with
pathlib.Pathinstead ofos.pathstring joins.
Fixed:
- The expected
a_proprevoutput is compared again. It sat in
tests/outputs/helper/proposalReviews.yml, where the test never looked, so it
went stale and the helper had no output coverage. Moved to
tests/outputs/a_proprev/proposalReviews.yaml, the name the test builds from the
helper name and the extension the helper writes, and refreshed to the current output. - Stop ANSI colors being passed when Gooey is being invoked
- The proposal review report now prints the reviewer's answers on the data management
and sharing plan and their other comments.a_proprevhas been prompting for both
since the DOE prompt update, butpropreport.txtnever rendered them, so the
answers were collected and silently dropped. Reviews written before those fields
existed are read with a default, and the NSF report is unchanged. - The expected
a_proprevoutput now carries the two DOE fields that were added to
the exemplar proposal review. The fixture is a snapshot of the whole
proposalReviewscollection, so adding a field to any document in it changes the
file, and the two changes were written against amainthat did not yet have the
other. OSError: [Errno 22] Invalid argumentwhen dumping collections on Windows under
python 3.14. A posix-styleurlorpathinregolithrc.jsonwas joined as a
string, producing a filename such as..\../rg-db-private/db\people.ymlthat mixes
/and\separators.