Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several improvements #2

Merged
merged 11 commits into from
Feb 28, 2016
Merged

Several improvements #2

merged 11 commits into from
Feb 28, 2016

Conversation

ProfFan
Copy link
Collaborator

@ProfFan ProfFan commented Feb 25, 2016

  • Changed sed script to be POSIX compliant (FreeBSD, Mac OS X)
  • Separated config from script
  • Get IP from system command directly

TODO:

  • Add a config option to let user choose to use address from DynDNS or directly from the OS

rehiy pushed a commit that referenced this pull request Feb 28, 2016
Merge pull request #2 from ProfFan/master
d567684 
Several improvements
@rehiy rehiy merged commit d567684 into rehiy:master Feb 28, 2016
@ProfFan
Copy link
Collaborator Author

ProfFan commented Feb 29, 2016

@anrip 好像有一点bug，能把我加到Collaborators里面吗？这几天我可以Maintain这个repo

@rehiy
Copy link
Owner

rehiy commented Feb 29, 2016

OK，我这段时间在忙别的项目，无法测试这个脚本，辛苦了

ProfFan added a commit that referenced this pull request Mar 1, 2016
@ProfFan
Merge pull request #2 from anrip/master
4462617 
Merge pull request #2 from ProfFan/master
@wbchn wbchn mentioned this pull request Mar 16, 2016
Closed
@chinattw chinattw mentioned this pull request Nov 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ProfFan @rehiy