Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types #6

Merged
merged 5 commits into from Aug 22, 2020
Merged

Add types #6

merged 5 commits into from Aug 22, 2020

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented Jul 30, 2020 •
edited
Loading

Upgrade hast-util-sanitize to ^3.0.0 to use its types

@pd4d10 pd4d10 changed the title Patch 1 Add types Jul 30, 2020
ChristianMurphy
ChristianMurphy requested changes Jul 30, 2020
View reviewed changes
package.json Show resolved Hide resolved
@ChristianMurphy ChristianMurphy requested a review from a team July 30, 2020 13:25
@ChristianMurphy ChristianMurphy added ☂️ area/types This affects typings 🦋 type/enhancement This is great to have 🧑 semver/major This is a change labels Jul 30, 2020
@codecov-commenter

This comment has been minimized.

Sign in to view
ChristianMurphy
ChristianMurphy approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pd4d10! LGTM

@ChristianMurphy ChristianMurphy requested a review from a team July 30, 2020 13:53
@wooorm
Copy link
Member

wooorm commented Jul 30, 2020

@ChristianMurphy As you approved, are we thus adding unified as a dep to all plugins? 🤔

@ChristianMurphy
Copy link
Member

Most unified plugins use the unified.Plugin type.
We have some options, dependencies to have the typings automatically install, peerDependencies for a semi-manual install. devDependencies for a fully manual install and needing instructions.
Based off past discussions my understand is unified is moving towards including the needed types automatically (though dependencies)
Did/do you have a different preference/interpretation?

@wooorm wooorm merged commit fdeff60 into rehypejs:main Aug 22, 2020
@wooorm
Copy link
Member

wooorm commented Aug 22, 2020

Thanks, released in 4.0.0!

@wooorm wooorm added the 💪 phase/solved Post is done label Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pd4d10 @codecov-commenter @wooorm @ChristianMurphy