Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types introduced in v4 aren't exposed via the package.json #6

Closed
ChristianIvicevic opened this issue Nov 11, 2020 · 0 comments · Fixed by #7
Closed

Types introduced in v4 aren't exposed via the package.json #6

ChristianIvicevic opened this issue Nov 11, 2020 · 0 comments · Fixed by #7
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem

Comments

@ChristianIvicevic
Copy link
Contributor

In #5 I forgot to add register the types in the package.json which has gone unnoticed until I tried to install the newly published package. I will be creating a PR to fix this issue in a few moments.
@ChristianIvicevic ChristianIvicevic added 🐛 type/bug This is a problem 🙉 open/needs-info This needs some more info labels Nov 11, 2020
@ChristianIvicevic ChristianIvicevic changed the title Types introduces in v4 aren't exposed via the package.json Types introduced in v4 aren't exposed via the package.json Nov 11, 2020
@ChristianIvicevic ChristianIvicevic mentioned this issue Nov 11, 2020
Merged
@wooorm wooorm closed this as completed in #7 Nov 12, 2020
wooorm pushed a commit that referenced this issue Nov 12, 2020
Add types to package.json
4dfc460 
Related to GH-4.
Related to GH-5.
Closes GH-6.
Closes GH-7.

Reviewed-by: Christian Murphy <christian.murphy.42@gmail.com>
Reviewed-by: Titus Wormer <tituswormer@gmail.com>
@wooorm wooorm added ☂️ area/types This affects typings ⛵️ status/released 🐛 type/bug This is a problem 👶 semver/patch This is a backwards-compatible fix and removed 🐛 type/bug This is a problem 🙉 open/needs-info This needs some more info labels Nov 12, 2020
@wooorm wooorm added the 💪 phase/solved Post is done label Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add types to package.json
2 participants
@wooorm @ChristianIvicevic