Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev bug) traffic from middleware plugins not throttled #48

Closed
NaitLee opened this issue May 25, 2022 · 1 comment
Closed

(dev bug) traffic from middleware plugins not throttled #48

NaitLee opened this issue May 25, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@NaitLee
Copy link

NaitLee commented May 25, 2022

I don't know if it's intended, but a middleware can also do large traffic.

To solve just swap this in index.ts

    .use(pluginsMiddleware())
    .use(throttler)

... or make it optional?

@rejetto
Copy link
Owner

rejetto commented May 25, 2022

I think throttling must be enforced also on new streams a plugin can make.
Only if we decide later to give the opportunity to avoid throttling, then it will be something you have to act to get it.
So, thanks for your report, I will swap as you suggested

@rejetto rejetto closed this as completed May 25, 2022
@rejetto rejetto added the bug Something isn't working label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants