-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TypeScript #33
Comments
Yea I'm happy to support this, I noticed they were setting up for multiple language support last time I was poking around too. First steps I can do are some refactors so we reference the JS language module that relay-compiler provides (a bunch of that stuff is hardcoded here atm such as file extensions). From what I can see, the RelayCompilerBin is a good reference point - it basically performs the same function as we do of setting up + configuring the relay compiler. But when it comes to checking it works with other languages, I'll need some help. I have zero experience with typescript and don't have the motivation or time right now to learn it |
Cool! No worries, I can do the TypeScript testing and come configuring and hopefully some of the work as well 🙆♂️ |
@koddsson There's a |
Sorry @danielholmes, I had a Christmas party on Saturday and didn't have time to dive into this. Something did break from RC1 to RC2 and now I get a |
Turns out I had the wrong |
I think we are good here, thanks for the help ✨ |
Hey hey @danielholmes 👋
I'm wondering if we can support TypeScript in
relay-compiler-webpack-plugin
? I've been poking around and it seems likerelay-compiler
now supports multiple languages and this has spawnedrelay-compiler-language-typescript
.I looked at the source and tried to debug a bit but can't seem to figure it out right now. I think we are hardcoding js as a parser config in the codebase and this should now be dynamic depending on the
language
options key.I'm more then willing to work on this and I'll be looking at this more soon but I figured I'd open this up in case you'd have any good ideas on how we can do this.
The text was updated successfully, but these errors were encountered: