This repository has been archived by the owner on May 24, 2023. It is now read-only.
Add Regex support to OMPS #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBasti
reviewed
Oct 8, 2019
omps/quay.py
Outdated
| @@ -259,7 +259,12 @@ def replace_registries(self, text): | |||
| for conf in self._replace_registry_conf: | |||
| old = conf['old'] | |||
| new = conf['new'] | |||
| if old in text: | |||
| regexp = conf['regexp'] | |||
There was a problem hiding this comment.
I'd like to have 'regexp' optional, respectively only old or regexp must be defined, not both, not none.
MartinBasti
reviewed
Oct 8, 2019
csomh
reviewed
Oct 8, 2019
rthallisey
force-pushed
the
regex-support
branch
from
5e83383
to
208b6d1
Compare
MartinBasti
reviewed
Oct 9, 2019
MartinBasti
reviewed
Oct 9, 2019
MartinBasti
reviewed
Oct 9, 2019
MartinBasti
reviewed
Oct 9, 2019
MartinBasti
reviewed
Oct 9, 2019
MartinBasti
reviewed
Oct 9, 2019
csomh
reviewed
Oct 9, 2019
csomh
approved these changes
Oct 9, 2019
There was a problem hiding this comment.
This looks good, but please squash the commits before merging.
Thanks @rthallisey!
The current pattern for registry string replacement only matches on whole strings. This pattern is very broad and lacks the precision to handle corner cases like strings that only end or begin with '/'. Regexes provide the precision needed to expand pattern matching to handle more precise string replacement. Make regexp backwards compatible Change strings to bools
rthallisey
force-pushed
the
regex-support
branch
from
d4de208
to
b35ebaf
Compare
|
Thanks @csomh & @MartinBasti! |
|
Deployed to the QA environment. |
|
Going to hold off on promoting this to prod to minimize any side-effects we might have on other releases scheduled for next week. |
|
Integration tests passed on QA. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current pattern for registry string replacement only matches on whole
strings. This pattern is very broad and lacks the precision to handle corner
cases like strings that only end or begin with '/'. Regexes provide the
precision needed to expand pattern matching to handle more precise string replacement.