Map RpmUnit.sha256sum to Pulp 'checksum', not 'checksums.sha256' #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For RPM units in Pulp, the SHA256 checksum is stored in two places: once in a 'checksums' dict and once again in a top-level 'checksum' field. We previously used the former, but only the latter is indexed (being a part of the unit key). Switching to 'checksum' can make searches much faster (and can make the difference between a search being feasible at all or being unusably slow), so let's do that. This should be safe, as I have confirmed in the Pulp code (linked within) that the checksum field is always forced to sha256, and also verified on our live systems that there are no units with a checksumtype!='sha256'. Motivation: noticed some queries were slower than expected while working on RHELDST-5435.
rbikar
approved these changes
Aug 23, 2021
negillett
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For RPM units in Pulp, the SHA256 checksum is stored in two places: once
in a 'checksums' dict and once again in a top-level 'checksum' field.
We previously used the former, but only the latter is indexed (being a
part of the unit key). Switching to 'checksum' can make searches much
faster (and can make the difference between a search being feasible at
all or being unusably slow), so let's do that.
This should be safe, as I have confirmed in the Pulp code (linked
within) that the checksum field is always forced to sha256, and also
verified on our live systems that there are no units with a
checksumtype!='sha256'.
Motivation: noticed some queries were slower than expected while working
on RHELDST-5435.