This repository was archived by the owner on Aug 6, 2025. It is now read-only.
Add mkcert for certificates #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Linux. By searching for `rootCA.pem` and `rootCA-key.pem` in a folder beneath `/mkcert` instead of assuming hardcoded locations we can make different volumes for Mac and Linux regardless of whether we actually run Mac or Linux.
|
This works for me on dory. Do need some where to document how ones docker-compose setup should be set up for this to work ... should should we just do it in this repo? In which case I'll just go ahead and update the readme |
danquah
reviewed
Feb 21, 2019
Create expected foldes in Dockerfile so they will be created while building the image instead of doing it when running the script (`/cert`) and not at all (`/mkcert`).
Dinghys wildcard syntax is just prefix with a dot (`.example.com`) where as mkcert uses an asterisk (`*.example.com`). So we rewrite the `VIRTUAL_HOST` if it starts with a dot. To do that we eed to split up the compound onliner finding the domains in either `MKCERT_DOMAINS`, `VIRTUAL_HOST` or hostname. But that is probably better for reading and understanding anyway (at least it is easier to document all steps now).
Make sure we are verbose in the log about which files we copy into /cert.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.