Skip to content

feat: upgrade domhandler to 3.3.0 and htmlparser2 to 4.1.0 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2020
Merged

feat: upgrade domhandler to 3.3.0 and htmlparser2 to 4.1.0 #40

merged 1 commit into from
Dec 13, 2020

Conversation

remarkablemark
Copy link
Owner

@remarkablemark remarkablemark commented Dec 13, 2020 •
edited
Loading

What is the motivation for this pull request?

feat: upgrade domhandler to 3.3.0 and htmlparser2 to 4.1.0

 domhandler   3.0.0  →  3.3.0
 htmlparser2  4.0.0  →  4.1.0

What is the current behavior?

dependencies:

What is the new behavior?

dependencies:

Replace domhandler DataNode with Comment and Text.

Checklist:

  • Tests
  • Types
  • Documentation

@remarkablemark
feat: upgrade domhandler to 3.3.0 and htmlparser2 to 4.1.0
2a748b8 
 domhandler   3.0.0  →  3.3.0
 htmlparser2  4.0.0  →  4.1.0

domhandler: https://github.com/fb55/domhandler/tree/v3.3.0
htmlparser2: https://github.com/fb55/htmlparser2/tree/v4.1.0

Replace domhandler `DataNode` with `Comment` and `Text`.
@remarkablemark remarkablemark added the dependencies Pull requests that update a dependency file label Dec 13, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 89.041% when pulling 2a748b8 on build/dependencies into 4bfbb85 on master.

@remarkablemark remarkablemark merged commit 093c34a into master Dec 13, 2020
@remarkablemark remarkablemark deleted the build/dependencies branch December 13, 2020 22:17
@remarkablemark
Copy link
Owner Author

remarkablemark commented Dec 13, 2020 •
edited
Loading

Published v0.5.0:

npm:

npm i html-dom-parser@0.5.0

Yarn:

yarn add html-dom-parser@0.5.0
0.4.0 0.5.0
html-dom-parser.min.js 5.91 kB 7.55 kB
html-dom-parser.js 18.2 kB 22.3 kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remarkablemark @coveralls