Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTML to DOM client parser #10

Merged
merged 2 commits into from
Aug 24, 2016
Merged

Fix HTML to DOM client parser #10

merged 2 commits into from
Aug 24, 2016

Conversation

remarkablemark
Copy link
Owner

@remarkablemark remarkablemark commented Aug 24, 2016 •
edited

Fixes #7

Tasks:

  • Fix DOMParser logic in the client parser
  • Throw an error if the first argument for the parser is invalid (not a string)
  • Add tests to check error handling

@remarkablemark
Fix HTML to DOM client parser
80ca2e2 
`DOMParser` was nesting certain elements (e.g., div) in `<html>`
and `body` so formatting the child nodes of document gave incorrect
results.

Update logic so that the correct nodes are parsed and formatted.
@remarkablemark
Throw an error if the first argument for the parser is not a string
8cd62a8 
This is to give the user gets feedback if the first argument is
invalid. Also, add tests to confirm behavior.
@remarkablemark remarkablemark added the bug Something isn't working label Aug 24, 2016
@remarkablemark remarkablemark self-assigned this Aug 24, 2016
@remarkablemark remarkablemark merged commit becc168 into master Aug 24, 2016
@remarkablemark remarkablemark deleted the html-to-dom-client branch August 24, 2016 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@remarkablemark remarkablemark

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@remarkablemark