Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue after 5.0.9 update #1228

Closed
pongells opened this issue Dec 18, 2023 · 3 comments · Fixed by #1229
Closed

Issue after 5.0.9 update #1228

pongells opened this issue Dec 18, 2023 · 3 comments · Fixed by #1229
Assignees
@remarkablemark
Labels
bug Something isn't working

Comments

@pongells
Copy link

Expected Behavior

I should be able to use Element

Actual Behavior

When I run my React app using Vite I get:

Uncaught SyntaxError: The requested module '/@fs/Users/.../node_modules/.vite/app/deps/html-react-parser.js?v=719515aa' does not provide an export named 'Element' (at list.tsx:6:31)

in list.tsx I have:

import { DOMNode, domToReact, Element } from "html-react-parser";

Steps to Reproduce

Try to use Element after 5.0.9 update.

Environment

  • Version: 5.0.9
  • Platform: Vite
  • Browser: Chrome
  • OS: MaxOs
@pongells pongells added the bug Something isn't working label Dec 18, 2023
@remarkablemark
Copy link
Owner

remarkablemark commented Dec 18, 2023 •
edited
Loading

You're right @pongells, I caused a regression in the latest release. I was able to reproduce the issue in https://codesandbox.io/p/devbox/html-react-parser-fg2jpw

I will prioritize a fix ASAP. Related to ce09a65#r135238939

remarkablemark referenced this issue Dec 18, 2023
@remarkablemark
fix(esm): fix ESM types by adding .mts declaration files
ce09a65
remarkablemark added a commit that referenced this issue Dec 18, 2023
@remarkablemark
fix(esm): make ESM exports explicit in index.mjs and utilities.mjs
3e0fd2b 
Fixes #1228

Vite fails with the error:

```
Uncaught SyntaxError: The requested module '/@fs/Users/.../node_modules/.vite/app/deps/html-react-parser.js?v=719515aa' does not provide an export named 'Element' (at list.tsx:6:31)
```
@remarkablemark remarkablemark mentioned this issue Dec 18, 2023
Merged
3 tasks
@remarkablemark
Copy link
Owner

Release:

@pongells
Copy link
Author

Thanks @remarkablemark , works like a charm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@remarkablemark remarkablemark

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(esm): make ESM exports explicit in index.mjs and utilities.mjs remarkablemark/html-react-parser
2 participants
@pongells @remarkablemark