Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow certs to be attached to specific processes. #1014

Merged
merged 2 commits into from
Oct 18, 2016
Merged

Conversation

ejholmes
Copy link
Contributor

Fixes #1013

With the addition of the ports key in the extended Procfile, it makes more sense to be able to attach a certificate to a process within the app, rather than the app itself. This is supported in the backend (CloudFormation scheduler), so this is just UI to expose it in the frontend.

This will allow you to attach different certificates to different processes (only 1 cert per process is allowed, since that's the case with ELB/ALB).

This should be fully backwards compatible with older emp clients. If the -p flag isn't provided, it just defaults to attaching the cert to the web proc:

$ emp cert-attach webCert -a acme-inc
$ emp cert-attach apiCert -p api -a acme-inc
$ emp apps 
acme-inc  web=webCert,api=apiCert  Aug 25 19:02

Copy link
Contributor

@phobologic phobologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ejholmes ejholmes merged commit d3d411c into master Oct 18, 2016
@ejholmes ejholmes deleted the multi-cert branch October 18, 2016 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants