Fix regression in env-load subcommand #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where env-load behaved inconsistently, where keys would be set to random values. The behavior is best described by https://github.com/golang/go/wiki/CommonMistakes#using-goroutines-on-loop-iterator-variables, which states that it's a mistake to use a pointer in a `range` loop without first copying it.
phobologic
approved these changes
Mar 23, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1061
This fixes an issue where env-load behaved inconsistently, where keys
would be set to random values. The behavior is best described by
https://github.com/golang/go/wiki/CommonMistakes#using-goroutines-on-loop-iterator-variables,
which states that it's a mistake to use a pointer in a
rangeloopwithout first copying it.
I feel like this is something that should be caught by
go vet, but isn't.