Maintenance mode #1086
Merged
Maintenance mode #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phobologic
approved these changes
Jun 1, 2017
cmd/emp/maintenance.go
Outdated
| Long: ` | ||
| Maintenance shows the current maintenance mode state of an app. | ||
| Example: | ||
| $ emp maintenance |
There was a problem hiding this comment.
maybe show that you should use -a in these docs.
| }, | ||
| { | ||
| "scale -l -a acme-inc", | ||
| "rake=0:1X scheduled=0:1X web=2:1X worker=0:1X", |
There was a problem hiding this comment.
Should we have some indication here that the stack is in maintenance mode so people aren't confused?
There was a problem hiding this comment.
I kinda waffled on that a bit. My current feeling is that this shouldn't change, since it would be a breaking change for scripts. We could return something like rake=0:1X scheduler=0:1X web=0:1X worker=0:1X, but then that's not entirely true, because web is still scaled to 2 in the release.
ejholmes
force-pushed
the
maintenance
branch
5 times, most recently
from
8678601
to
a01382a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for putting applications into "maintenance mode", which can be useful for doing things that might require complete downtime, like DB upgrades.
You can put an application into maintenance mode using the
emp maintenance-enablecommand, which masks the scale of all processes to 0. You can then disable maintenance mode withemp maintenance-disable, which unmasks the scale and returns everything back to normal.