Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull emp CLI into cmd/emp #712

Merged
merged 2 commits into from
Jan 5, 2016
Merged

Pull emp CLI into cmd/emp #712

merged 2 commits into from
Jan 5, 2016

Conversation

ejholmes
Copy link
Contributor

@ejholmes ejholmes commented Jan 2, 2016

Depends on #710.

One of the only reasons emp was in a separate repo previously was because we needed to rewrite import paths with godep save -r ./... to make it "go gettable" with Go 1.5+ and the vendor directory, this is no longer necessary.

This has multiple benefits:

  1. Releasing new features is more "atomic" since we can release a daemon and client that are always compatible with each other.
  2. It was common for CLI tests to fail before because something wasn't merged into remind101/emp. This won't be an issue anymore.

TODO

  1. Update docs about installing emp.
  2. Add a deprecated notice on remind101/emp.

ejholmes added a commit that referenced this pull request Jan 5, 2016
@ejholmes ejholmes merged commit 24b713f into vendor Jan 5, 2016
@ejholmes ejholmes deleted the vendor-emp branch January 5, 2016 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant