Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow emp run to be used with unofficial docker registries. #740

Merged
merged 2 commits into from
Jan 22, 2016

Conversation

ejholmes
Copy link
Contributor

Fixes #739.

This extracts the logic that we were using to pull from unofficial registries during deployments into the dockerutil client so it can be re-used for emp run.

Tested this locally with the quay.io/remind/acme-inc image and it works as expected.

@phobologic
Copy link
Contributor

👍 awesome

ejholmes added a commit that referenced this pull request Jan 22, 2016
Allow emp run to be used with unofficial docker registries.
@ejholmes ejholmes merged commit 7f72e38 into master Jan 22, 2016
@ejholmes ejholmes deleted the pull-run branch January 22, 2016 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants