Add an ImageBuilder implementation for Conveyor #747
Conversation
|
|
||
| a, err := c.client.Build(w, conveyor.BuildCreateOpts{ | ||
| Repository: event.Repository.FullName, | ||
| Branch: "", // TODO, |
There was a problem hiding this comment.
This is where things get a little weird, since we don't actually know if the ref that the deployment was triggered for was a branch, tag or sha.
This should probably be event.Deployment.Ref. Ultimately, Conveyor will need to support "branchless" builds, which should be pretty easy since the branch is only used to optimize the layer cache and isn't explicitly necessary to perform a build.
There was a problem hiding this comment.
Actually, I think we should not set Branch at all since we really have no idea what the ref was. In most cases, Conveyor will have already started the build, using the branch cache and Empire will just wait for it to complete.
ejholmes
force-pushed
the
conveyor
branch
2 times, most recently
from
f7bd541
to
fded317
Compare
|
Note to self. We should definitely have some cancellations (context.Deadline) around deployment. Don't wanna have goroutines with pending deployments hanging around forever. |
|
Ok. I think this is good to merge now. Been running this in staging for the last couple of days and no major issues aside from ejholmes/cloudwatch#4 |
| Name: FlagGithubDeploymentsImageTemplate, | ||
| Value: github.DefaultTemplate, | ||
| Usage: "A Go text/template that will be used to determine the docker image to deploy.", | ||
| Usage: "A Go text/template that will be used to determine the docker image to deploy. This flag is only used when `--" + FlagGithubDeploymentsImageBuilder + "` is set to `template`.", |
There was a problem hiding this comment.
Is this required if FlagGithubDeploymentsImageBuilder is set to template?
|
👍 |
Add an ImageBuilder implementation for Conveyor
This adds an implementation of the ImageBuilder interface backed by Conveyor. This means that if you're using Conveyor to build Docker images, it's no longer necessary to wait for the image to finish building before triggering a GitHub Deployment.
If a GitHub Deployment request is received by Empire, Empire will consult with Conveyor to obtain the Docker image for the given git sha, building it if necessary.
Not yet ready to merge, still needs some testing on both Conveyor's side and Empire's side.