Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache task definitions #902

Merged
merged 2 commits into from
Jul 26, 2016
Merged

Cache task definitions #902

merged 2 commits into from
Jul 26, 2016

Conversation

ejholmes
Copy link
Contributor

@ejholmes ejholmes commented Jun 24, 2016

This is a small performance optimization that takes into account the fact that task definitions can essentially be treated as immutable, when keying off the ARN.

Describing task definitions is a pretty expensive call, both in time (it's N+1, and slow) and in throttling. This should help quite a bit with emp ps performance, once the cache is filled.

TODO

  • Tests
  • Don't cache if the TaskDefinition is not an ARN.

@phobologic
Copy link
Contributor

Cool idea.

@mwildehahn
Copy link
Contributor

mwildehahn commented Jul 26, 2016

👍

@ejholmes ejholmes merged commit fd9f969 into master Jul 26, 2016
@ejholmes ejholmes deleted the cache-task-definitions branch July 26, 2016 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants