New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds example to show "page not found" implementation #3251

Merged

timdorr merged 2 commits into remix-run:master from hegdeashwin:master

Apr 12, 2016

Contributor

hegdeashwin commented Apr 5, 2016

Hope I have done is correct! This example will help to show "page not found" implementation on client side. Refs my comments on Redirect to NotFoundRoute #458
If its correct then I would like to update the doc too for Page not found on client side. It might help in Docs Improvements #2933 fix "Document how to make a client-side "not found" route (i.e. with )" under Potential Improvements

hegdeashwin added 2 commits

April 6, 2016 01:32


          Adds example to show "page not found" implementation

050ce69


          Fixes build remix-run#3263 failed

801f38f

timdorr added the examples label

Member

timdorr commented Apr 12, 2016

This is good for client side 404's, but we should keep in mind that this doesn't handle the server side case (which is still pending). LGTM though. Thanks!

timdorr merged commit 1a2798b into remix-run:master

zhiyelee commented Jul 22, 2016

Exactly, the status code is 200 instead of 404

lock bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet