Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-router): fix useMatch's description #9479

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

m-shojaei
Copy link
Contributor

Fixing useMatch description as the current one does not reflect the hook's signature

Fixing `useMatch` description as the current one does not reflect the hook's signature
@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2022

⚠️ No Changeset found

Latest commit: 23bfef7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 20, 2022

Hi @m-shojaei,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@MichaelDeBoey MichaelDeBoey changed the title Fix useMatch description chore(react-router): fix useMatch's description Nov 8, 2022
@MichaelDeBoey
Copy link
Member

@m-shojaei Could you please sign the CLA? Otherwise we can't merge this one.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 21, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@m-shojaei
Copy link
Contributor Author

@MichaelDeBoey Signed! :)

@MichaelDeBoey MichaelDeBoey merged commit fd4383d into remix-run:dev Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants