fix: preserve method on 307/308 redirects #9597
Merged
+360
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: acc7066 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Nov 15, 2022
brophdawg11
commented
Nov 15, 2022
brophdawg11
commented
Nov 15, 2022
brophdawg11
commented
Nov 15, 2022
machour
reviewed
Nov 15, 2022
Co-authored-by: Mehdi Achour <machour@gmail.com>
MichaelDeBoey
approved these changes
Nov 17, 2022
This was referenced Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the spec, 307 and 308 redirects should preserve the HTTP method and request body and re-submit to the new location. The spec is ambiguous for 301/302/303 so those will still always redirect using
GET.Closes remix-run/remix#4356