-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-router): improve memoization for context providers #9983
Conversation
🦋 Changeset detectedLatest commit: 1417fdb The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @appden, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
cf45b2c
to
695a3db
Compare
This will reduce some unnecessary re-renders where the context is accessed.
695a3db
to
55edd61
Compare
@appden Thanks for this! Do you happen to have an example of the |
No prob! I made that commit because I originally neglected to run tests (doh) and saw several tests in |
Ah ok if they were caused by these changes that makes sense. I'll try to do some deeper testing on this next week 👍 |
Hi @brophdawg11, kindly follow up to see if you've had the chance to test this further. Thanks! |
Thanks @appden! |
This will reduce some unnecessary re-renders where the context is accessed.