Skip to content

Numeric Protocols naming to match Swift3, methods with mutable semantics marked as deprecated, and their correct counterparts added #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

ambientlight
Copy link
Contributor

Please note that in Swift, reverse()/subtract()/intersect() are mutable methods that are modifying current instance, instead of yielding a new modified one.

To match Swift3 semantics, reverse()/subtract()/intersect() has been marked deprecated and their immutable counterparts were added.

Also + overloaded operator added to Set/Array.

And please note the purpose of following added initializer

// our aggregate operations like .map, .filter will errase our collection type and yield ISequence
// so in order to have consistency with apple swift compiling
// we will do something like [String](fields.map(fieldNameWithRemovedPrivatePrefix)).someArrayFunc
public convenience init(_ sequence: ISequence<T>) {
       return self.init(sequence: sequence)
}

… Swift semantics (intersect, subtract marked as deprecated, then have mutating semantics and should not be used)
…old swift2 aliases are not removed so that they won’t be breaking)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant