Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature sub range (work area) for clip #631

Merged
merged 19 commits into from
Oct 15, 2021

Conversation

ankeshp03
Copy link
Contributor

Resolve/Add feature #603

This PR adds the feature to put in/out points (work area) for clips.

remotion

Suggested Scope:

  • Set in/out points by placing the playhead at a certain position and then click a UI button to set in and out points.
  • When switching comps it's not necessary to remember the work area, nice to have, but not a must-have
  • Dragging is nice, but totally not a must-have, so skip it in the first version

Points to remember:

  • In and Out points cannot be the same, the minimum gap is 1 frame
  • In-point cannot be greater than out-point and vice versa.
  • Playhead cannot be set in position outside the working area (area between in and out points).
    Playhead will automatically start from in-point on resuming play.
  • In/Out point buttons on the preview toolbar are toggle buttons.

Blocker in Scope

  • Implementing drag is challenging since we already have a TimelineDragHandler which changes the playhead position on drag. Drag for work area might affect the TimelineDragHandler functionality.

@JonnyBurger
Copy link
Member

Woah that looks great! Thanks a lot. I'm now gone for two days, expect some delay in reviewing, can't wait to look at it though 👀

@ankeshp03
Copy link
Contributor Author

Thank you @JonnyBurger 😀
Sure, review it whenever you are free.

@JonnyBurger
Copy link
Member

My mind is blown! :D This is really good!

Thanks a lot, very lucky to receive such a nice PR!
I'm gonna refine it a little bit to add keyboard shortcuts, make it visually more appealing, add docs, add dragging, and remove it when it's a still. Then gonna announce it big 🥳 Feel free to work on it as well.

I'm already adding a hacktoberfest-accepted label and paying out the bounty.

@marcusstenbeck
Copy link
Contributor

@ankeshp03 Really, really nice work!

@ankeshp03
Copy link
Contributor Author

My mind is blown! :D This is really good!

Thanks a lot, very lucky to receive such a nice PR! I'm gonna refine it a little bit to add keyboard shortcuts, make it visually more appealing, add docs, add dragging, and remove it when it's a still. Then gonna announce it big 🥳 Feel free to work on it as well.

I'm already adding a hacktoberfest-accepted label and paying out the bounty.

Thank you so much @JonnyBurger. 😃
I am glad that you found the PR good.
Never expected such a reply, you made my day!

I will surely look to make it better.
And try to contribute to this project as much as possible.

Thank you for the bounty, this is my first time ever getting paid for a PR. 😅

@ankeshp03
Copy link
Contributor Author

@ankeshp03 Really, really nice work!

Thank you so much @marcusstenbeck. 😄

@JonnyBurger JonnyBurger merged commit 4495e44 into remotion-dev:main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants