Skip to content

Implementation of address translation #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Implementation of address translation #21

wants to merge 34 commits into from

Conversation

febyeji
Copy link
Collaborator

@febyeji febyeji commented Jul 28, 2025 •
edited
Loading

  • Handle cases for TranslationStart and TranslationEnd in run_outcome

@tperami tperami changed the base branch from main to feature/tlb August 19, 2025 11:00
@febyeji febyeji force-pushed the feature/tlb-filling branch from c5bf368 to 204bc25 Compare August 26, 2025 02:50
@febyeji febyeji force-pushed the feature/address-translation branch from 82f1176 to 5f7e0e8 Compare August 26, 2025 07:38
@febyeji febyeji changed the base branch from feature/tlb-filling to feature/tlb-invalidation August 26, 2025 07:41
@febyeji febyeji marked this pull request as ready for review August 26, 2025 07:42
@febyeji febyeji force-pushed the feature/tlb-invalidation branch 3 times, most recently from 035d4c8 to 9e82e2a Compare August 29, 2025 09:36
@febyeji febyeji force-pushed the feature/address-translation branch from 5f7e0e8 to 1d5fe21 Compare August 29, 2025 09:38
tperami
tperami reviewed Sep 4, 2025
View reviewed changes
tperami
tperami reviewed Sep 4, 2025
View reviewed changes
Copy link
Collaborator

@tperami tperami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some preliminary comments

@febyeji febyeji force-pushed the feature/tlb-invalidation branch from 9e82e2a to 8489977 Compare September 5, 2025 01:33
@febyeji febyeji force-pushed the feature/address-translation branch from 1d5fe21 to b56b9b7 Compare September 5, 2025 01:33
@febyeji febyeji force-pushed the feature/tlb-invalidation branch from 8489977 to c05e20f Compare September 5, 2025 01:38
@febyeji febyeji force-pushed the feature/address-translation branch 2 times, most recently from 1d13aef to 4b24d13 Compare September 5, 2025 04:27
@febyeji febyeji force-pushed the feature/address-translation branch from b9ebbb4 to f8285f9 Compare September 16, 2025 04:29
@febyeji febyeji force-pushed the feature/tlb-invalidation branch from c05e20f to 72441d9 Compare September 17, 2025 04:30
@febyeji febyeji force-pushed the feature/address-translation branch from 8d806ed to 8c139bf Compare September 17, 2025 04:35
@febyeji febyeji force-pushed the feature/tlb-invalidation branch from 72441d9 to fd105de Compare September 18, 2025 03:24
@febyeji febyeji force-pushed the feature/address-translation branch from c44362c to 7bcad3b Compare September 18, 2025 03:30
@febyeji febyeji mentioned this pull request Sep 18, 2025
Open
tperami
tperami reviewed Sep 22, 2025
View reviewed changes
Copy link
Collaborator

@tperami tperami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very good work, thanks! My comments are mostly about code style and edge-case semantics issue
There is also a bit of discussion we need to have at next meeting about the semantics of TakeException

@febyeji febyeji force-pushed the feature/address-translation branch from f8f4f4c to a43884a Compare September 24, 2025 09:33
@febyeji febyeji force-pushed the feature/tlb-invalidation branch from fd105de to c307584 Compare September 24, 2025 09:34
@febyeji febyeji force-pushed the feature/address-translation branch from a43884a to 780d702 Compare September 24, 2025 09:34
@febyeji febyeji force-pushed the feature/tlb-invalidation branch from c307584 to 67dd3e1 Compare September 30, 2025 15:45
@febyeji febyeji force-pushed the feature/address-translation branch from 780d702 to 1d619d3 Compare September 30, 2025 17:34
@tperami tperami force-pushed the feature/tlb-invalidation branch from 5b700f5 to 062de11 Compare October 3, 2025 11:54
Base automatically changed from feature/tlb-invalidation to main October 3, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tperami tperami tperami left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@febyeji @tperami