Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase CLI robustness #59

Merged
merged 3 commits into from
Aug 22, 2017
Merged

Increase CLI robustness #59

merged 3 commits into from
Aug 22, 2017

Conversation

ijovan
Copy link
Contributor

@ijovan ijovan commented Aug 22, 2017

No description provided.

@ijovan ijovan requested a review from shiroyasha August 22, 2017 13:49
lib/sem.rb Outdated
def on_resource_not_found(exception)
puts "[ERROR] Resource not found."
puts ""
puts "Resource not found: #{exception.message}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit too generic. Can we have more specific, nicer messages like, [ERROR] User ijovan not found ?

@ijovan ijovan merged commit 5a7fbbe into master Aug 22, 2017
@ijovan ijovan deleted the ji/robustness branch August 22, 2017 14:21
This was referenced Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants