Skip to content

Conversation

shokimble
Copy link

Made changes to support tensorflow 1.8.0 and to support play store/react native requirement of all new apps requiring SDK level 26 or above

@shokimble
Copy link
Author

Sorry this is only for Android. I'll look at adding IOS tomorrow. Might be best to hold off any merge until then.

@socksrust
Copy link

can anyone merge this?

@socksrust
Copy link

cc @shokimble

@socksrust
Copy link

i already tested for android and works

@gianpaj
Copy link

gianpaj commented Sep 15, 2018

@shokimble can you fix the travis build?

I believe you just need to update android-23 to android-26 under

 android:
   components:
     // here ...

@jazzystring1
Copy link

I tried it in android and it works. However im getting a different result in android. Have you all encountered this? I converted my keras model to pb.

@reneweb
Copy link
Owner

reneweb commented Oct 28, 2018

Sorry for late reply one this. The main reason I was holding off on doing this change was that the Android version would diverge from the iOS one. It though looks like that Google will not update the iOS version anymore as the way forward is using Tensorflow Lite. For the time being we might just update the Android version on it's own and update the Readme that there the Android Tensorflow version is different than the iOS one until we upgrade to Tensorflow Lite?

sometimescasey added a commit to sometimescasey/react-native-tensorflow that referenced this pull request Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants