-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add jsonnet-bundler support #12720
Conversation
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
The only remaining thing on my todo is "add jb to https://github.com/containerbase/buildpack". How do I do that? |
Marking as draft, as it needs a buildpack update first. |
Please open an issue there to discuss. Add some references how to install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please do a real run with binarySource=docker
?
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
I did a real run with binarySource=docker and it failed because the sidecar image isn't published yet. I've inspected the output and it looks like it's doing the right thing (tm)
|
renovate is missing on https://github.com/renovatebot/docker-sidecar, so the image isn't yet updated with latest buildpack v2.3.0 |
Shall I make a PR to bump the version/add renovate? |
nope, the app simply wasn't installed on that repo, which is now fixed and the update should be release in a couple of minutes |
ok, released: https://hub.docker.com/r/renovate/sidecar/tags Please retry docker binary source |
Retried, and it failed with:
Did I miss anything? |
Your local user id is probably not 1000, so the docker sidecar can't read the git checkout. |
That wasn't it. I was connecting to a remote docker daemon and volumes weren't working (suprise). When I ran it with a local docker daemon it worked:
|
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation looks good to me!
🎉 This PR is included in version 29.17.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
This PR adds support for jsonnet-bundler.
TODO:
extractPackageFile()
updateArtifacts()
Context:
Closes #9800
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: