Skip to content

Specify minimum engine requirement of Node 18 #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

mattt
Copy link
Contributor

@mattt mattt commented Aug 4, 2023

Several issues have been opened with questions or problems related to fetch and Node.js versions.

In #100, I wrote:

Replicate should work on any supported version of Node provided that there's a fetch function available, so I'm not sure updating the engines for the package would be appropriate.

That comment was based on an incorrect understanding of npm. According to the docs, engine requirements are advisory, and don't prevent a client from installing a package Unless the user has set the engine-strict config flag.

This PR sets the engines key in the package.json file to specify a requirement of Node >= 18.0.0.

@mattt mattt requested a review from zeke August 4, 2023 18:28
@zeke zeke merged commit 9945095 into main Aug 4, 2023
@zeke zeke deleted the mattt/node-engine branch August 4, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants