-
Notifications
You must be signed in to change notification settings - Fork 233
Integration tests for common runtimes #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c186d5
to
06a4f58
Compare
This commit adds some basic integration tests and a new ci workflow for our three common runtimes, nodejs with commonjs and esm as well as TypeScript. The aim here is to ensure that the interface is consistent even if we refactor/restructure the package. The change does require a REPLICATE_API_TOKEN to be available in the CI environment.
06a4f58
to
a4d019a
Compare
😍 |
zeke
reviewed
Jan 12, 2024
zeke
reviewed
Jan 12, 2024
zeke
reviewed
Jan 12, 2024
zeke
reviewed
Jan 12, 2024
zeke
reviewed
Jan 12, 2024
zeke
reviewed
Jan 12, 2024
zeke
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this!
I added a few suggestions for renamed test inputs, partly for fun, but also to make them more distinguishable from each other in case of possible test failures.
Co-authored-by: Zeke Sikelianos <zeke@sikelianos.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently in the process of spending some spare time improving the structure of this repository. Ideally I want us to get to the point where we have three things:
a native esm friendly version of the repository (not just relying on the nodejs dual module system)
the
index.d.ts
generated automatically usingtsc --emitDeclarationOnly
.a singleton instance of
Replicate
as the default export for the package so our examples can be as simple as:I'll follow up on this one in a second PR with more details and we'll still retain the constructor as a way of customizing the library.
This commit adds some basic integration tests and a new ci workflow for our three common runtimes, nodejs with commonjs and esm as well as TypeScript. The aim here is to ensure that the interface is consistent even if we refactor/restructure the package.
The change does require a
REPLICATE_API_TOKEN
to be available in the CI environment which I've added.