Fix streaming example #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example to use replicate.stream was wrongly checking the event type and was not producing any output.
|
Related to #197 |
mattt
reviewed
Feb 16, 2024
Co-authored-by: Mattt <mattt@me.com>
Co-authored-by: Mattt <mattt@me.com>
Removing the console.dir since it's no longer relevant
|
Looks good to me! I did remove the |
|
Excellent. Thanks again for your help with this, @dkundel! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example to use replicate.stream was wrongly checking the event type and was not producing any output. I adjusted the example so that it works. The
event &&in front of theevent.event === 'output'check seems unnecessary as I can't think of a scenario whereeventwould be false-y and evenevent.eventseems to always be of type string but I left it for now in case I'm missing something.