Skip to content

Conversation

areed
Copy link
Contributor

@areed areed commented Jun 29, 2017

Generate models from the Vendor API's Swagger spec. The generated http transport code was too messy to be useful.

The tests are integration tests, not unit tests. Perhaps they should be in a separate package?

@areed areed requested a review from emosbaugh June 29, 2017 18:51
client/client.go Outdated
)

// A Client communicates with the Replicated Vendor API.
type Client struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanna add a Client interface?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@areed areed merged commit 1bb824a into replicatedhq:master Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants